On Wed, Feb 19, 2025 at 22:27:09 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu <danielwuwy@xxxxxxx> > > This change contains QMP requests for ThrottleGroup > > * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" > * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" > * ThrottleGroup is deleted by reusing "qemuMonitorDelObject" > * ThrottleGroup is added by reusing "qemuMonitorAddObject" > * "qemuMonitorMakeThrottleGroupLimits" will be used by building qemu cmd as well > > Signed-off-by: Chun Feng Wu <danielwuwy@xxxxxxx> > > * change throttle group config conversions P to U allow zero. > * Apply suggested coding style changes. > > Signed-off-by: Harikumar Rajkumar <harirajkumar230@xxxxxxxxx> > --- > src/qemu/qemu_monitor.c | 34 +++++++++ > src/qemu/qemu_monitor.h | 14 ++++ > src/qemu/qemu_monitor_json.c | 129 +++++++++++++++++++++++++++++++++++ > src/qemu/qemu_monitor_json.h | 14 ++++ > 4 files changed, 191 insertions(+) > > diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c > index c069d17265..015f8f11cc 100644 > --- a/src/qemu/qemu_monitor.c > +++ b/src/qemu/qemu_monitor.c [...] > +int > +qemuMonitorGetThrottleGroup(qemuMonitor *mon, > + const char *groupname, > + virDomainBlockIoTuneInfo *reply) The getter is used only in tests which makes no sense. If it's not used just don't add it. I've noticed it by this hunk bein misplaced.
