Re: [PATCH v2 3/3] qemuxmlconftest: Add test cases for broken and missing XML files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/9/24 14:40, Peter Krempa wrote:
> Add test cases for few edge cases which excercise the XML reporting from
> libxml2 in anticipation of upcoming changes of behaviour.
> 
> 'virschematest' must skip parsing of the broken file altogether so this
> patch adds infrastructure to allow that.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  .../broken-xml-invalid.x86_64-latest.err             |  3 +++
>  tests/qemuxmlconfdata/broken-xml-invalid.xml         |  1 +
>  .../nonexistent-file.x86_64-latest.err               |  1 +
>  tests/qemuxmlconftest.c                              |  8 +++++++-
>  tests/testutilsqemu.h                                |  1 +
>  tests/virschematest.c                                | 12 ++++++++++++
>  6 files changed, 25 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxmlconfdata/broken-xml-invalid.x86_64-latest.err
>  create mode 100644 tests/qemuxmlconfdata/broken-xml-invalid.xml
>  create mode 100644 tests/qemuxmlconfdata/nonexistent-file.x86_64-latest.err
> 


> diff --git a/tests/virschematest.c b/tests/virschematest.c
> index 9b6649a6cf..e89730e8dc 100644
> --- a/tests/virschematest.c
> +++ b/tests/virschematest.c
> @@ -36,6 +36,7 @@ struct testSchemaEntry {
>      const char **exceptions; /* optional NULL terminated list of filenames inside
>                                  directory where the expected validation result is
>                                  inverted */
> +    const char **skip; /* list of files to skip altogether */

NULL terminated list, please.

Michal



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux