[OS-BUILD PATCH] [redhat] scripts: sort dumped keys in uki_create_json.py

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Patrick Talbert <ptalbert@xxxxxxxxxx>

[redhat] scripts: sort dumped keys in uki_create_json.py

The order of the keys in the json output may change causing unnecessary
churn in the dist-git diffs. Fix this by setting sort_keys=True in the
json.dump() call. Outside of locale sorting differences this should
provide a more stable experience.

Signed-off-by: Patrick Talbert <ptalbert@xxxxxxxxxx>

diff --git a/redhat/scripts/uki_addons/uki_create_json.py b/redhat/scripts/uki_addons/uki_create_json.py
index blahblah..blahblah 100755
--- a/redhat/scripts/uki_addons/uki_create_json.py
+++ b/redhat/scripts/uki_addons/uki_create_json.py
@@ -86,7 +86,7 @@ def create_json(addons):
 
 def write_json(obj, dest_file):
     with open(dest_file, 'w') as f:
-        json.dump(obj , f, indent=4)
+        json.dump(obj , f, indent=4, sort_keys=True)
     print(f'Processed addons files are in {dest_file}')
 
 if __name__ == "__main__":

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3817

-- 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux