Hi, Fabio Estevam writes: > MX28 Reference Manual states the following about the CLKGATE bit of register HW_CLKCTRL_SAIF0: > > "The DIV field can change ONLY when this clock gate bit field is low." > > So clear this bit prior to writing to the DIV field as required. > > This also fixes the following error during mxs-sgtl5000 probe. > > [ 0.660000] saif0_clk_set_rate: divider writing timeout > [ 0.670000] mxs-sgtl5000: probe of mxs-sgtl5000.0 failed with error -110 > [ 0.670000] ALSA device list: > [ 0.680000] No soundcards found. > > Audio is functional after this change. > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > --- > arch/arm/mach-mxs/clock-mx28.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c > index 5d68e41..f85c09d 100644 > --- a/arch/arm/mach-mxs/clock-mx28.c > +++ b/arch/arm/mach-mxs/clock-mx28.c > @@ -475,6 +475,8 @@ static int name##_set_rate(struct clk *clk, unsigned long rate) \ > return -EINVAL; \ > \ > reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_##rs); \ > + \ > + reg &= ~BM_CLKCTRL_##rs##_CLKGATE; \ > reg &= ~BM_CLKCTRL_##rs##_DIV; \ > reg |= div << BP_CLKCTRL_##rs##_DIV; \ > __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_##rs); \ > Now you are doing clk_enable()'s business in clk_set_rate(). The same result could be achieved by calling clk_enable() prior to clk_set_rate(). clk_set_rate() could simply return an error code, if the clock is not enabled. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx ___________________________________________________________ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel